XWIKI-22746: Images do not have an aria-label in the xwiki-slash dropdown for CKEditor #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down for CKEditor * Added some style to hide "empty" HTML elements for icons. (cherry picked from commit 5f6c494)
…down for CKEditor * Codestyle
…down for CKEditor * Updated comment
mflorea
reviewed
Jan 10, 2025
| This is especially important for assistive tech users (regular users cannot see the image if there's no source). | ||
| Note that this extra style is required because the itemTemplate feature of CKEditor autocomplete | ||
| is not powerful enough to support our specific usecase. | ||
| since 16.10.3 |
There was a problem hiding this comment.
Suggested change
| since 16.10.3 | |
| @since 16.10.3 |
We don't usually mention since version in CSS. It looks a bit strange without the @ but I'll leave it to you to decide (remove it, keep it as it or add @).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22746
Changes
Description
Clarifications
EditSheet. This style was removed on the 19th of December in 1727219 ..jscontains fixes that are generic for all autocomplete uses.ItemTemplates(we should probably update them to be a bit more consistent) but the selectors used should fix all three.Screenshots & Video
None, no visual changes.
Executed Tests
I successfully built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins ;mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/.After bringing the updated jars in my local distrib, I was able to test the changes out, and the style applied as expected.
I ran
mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker -Dgradle.cache.local.enabled=false -Dgradle.cache.remote.enabled=false -Dit.test=LocalizationIT#paragraphQuickAction_en -Dxwiki.test.ui.wcag=trueboth with and without the changes. I could reproduce the issue reported by CI without the changes, and after the change there was no WCAG fail anymore.Expected merging strategy
Reasons: