-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWIKI-22746: Images do not have an aria-label in the xwiki-slash dropdown for CKEditor #3784
Open
Sereza7
wants to merge
4
commits into
xwiki:master
Choose a base branch
from
Sereza7:XWIKI-22746
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7469e7f
XWIKI-22746: Images do not have an aria-label in the xwiki-slash drop…
Sereza7 d999bc6
XWIKI-22746: Images do not have an aria-label in the xwiki-slash drop…
Sereza7 ee7cfc7
XWIKI-22746: Images do not have an aria-label in the xwiki-slash drop…
Sereza7 3def9ca
Merge branch 'xwiki:master' into XWIKI-22746
Sereza7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
...orm-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-slash/autocomplete.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* | ||
* This is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU Lesser General Public License as | ||
* published by the Free Software Foundation; either version 2.1 of | ||
* the License, or (at your option) any later version. | ||
* | ||
* This software is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
* Lesser General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Lesser General Public | ||
* License along with this software; if not, write to the Free | ||
* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA | ||
* 02110-1301 USA, or see the FSF site: http://www.fsf.org. | ||
*/ | ||
|
||
/* We hide completely icons in the CKEditor autocomplete items that are not used and therefore empty. | ||
This is especially important for assistive tech users (regular users cannot see the image if there's no source). | ||
Note that this extra style is required because the itemTemplate feature of CKEditor autocomplete | ||
is not powerful enough to support our specific usecase. | ||
since 16.10.3 | ||
*/ | ||
.ckeditor-autocomplete-item-head { | ||
& img[src=""], | ||
& img:not([src]), | ||
& .ckeditor-autocomplete-item-icon-wrapper > span[class=""], | ||
& .ckeditor-autocomplete-item-icon-wrapper > span:not([class]) { | ||
display: none; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't usually mention since version in CSS. It looks a bit strange without the
@
but I'll leave it to you to decide (remove it, keep it as it or add@
).