-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Create bundled and non-bundled (downloadable dependencies/packages) versions #256
base: master
Are you sure you want to change the base?
Conversation
Moved plugins declaration
… clean architecture
feat(NEW APP): Created a Jetpack Compose test app
perf: Improved StreamProcessExtractor
feat: Started plugin downloader feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yt-dlp but updates of it in commit a71509
refactor: Optimized imports in `library` module
The plugins support is almost finished; I have to change some things related to the initPython function and even the FFMpeg and Aria2c modules of the lib, but the YoutbeDL module itself can start to be reviewed. |
library/src/main/java/com/yausername/youtubedl_android/util/plugins/PluginsUtil.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/yausername/youtubedl_android/YoutubeDL.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/yausername/youtubedl_android/util/files/FilesUtil.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/yausername/youtubedl_android/YoutubeDL.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/yausername/youtubedl_android/YoutubeDL.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/yausername/youtubedl_android/Constants.kt
Outdated
Show resolved
Hide resolved
refactor: Separated the dependencies ensure from the init function
The |
⚠️ (WIP): Created product flavors for `:library` module - nonBundled version not finished and Android doesn't take it as a product variant
@JunkFood02 Can we talk about how we should handle the libraries downloading? I mean. Should the download function be inside the |
EDIT: FIXEDSeems to be an error at build time because of the app, here is the log. I think that the targetConfiguration isn't correct since I would say that the target should be "bundled" or "nonbundled" but when using those cases Gradle isn't able to find the library: implementation project(":library") targetConfiguration("bundledDebugRuntimeElements") |
- Added flavor to the test app - Preparing the other dependencies for flavor-ization
… an abstract function
This PR is quite large (4000+ LoC) and hard to review. Could we please split it to smaller and more focused PRs, each addressing a specific topic? |
The changes that are necessary for this functionality require all the work put into this PR since it means almost a rewrite of the library. I will still try to adjust the code to reduce the number of lines and changes, but please keep in mind that this proposed separation requires the changes made. |
I will start by removing the Jetpack Compose app |
We can just make a pull request depending on another, which means a pull request could only be merge after all it's dependencies got merged into the target branch. This allows us to gradually applying the changes and review them in smaller chunks, making the process more manageable. |
That's interesting and cool. Can we create those chunks in some way or I have to create different branches with manual changes? |
I'm afraid you'll have to do so by hand since github doesn't support such cool pull requests while gitlab is offering this as a paid feature You can start with building upon an existing branch. Submit a pull request when you're ready for a new, separate feature and create a new branch based of the current branch for further changes. Just make sure each branch(PR) focus on a single modification or topic for clarity. Also, when developing on parallel branches simultaneously, avoid modifying the same files. You know what would happen 😈 |
For example: you can start with the
|
Hahah okay, thanks for the help! I will do this as it should be done, as you told me. I'll keep this PR open for a while, but when I think the other smaller PRs cover everything done in this one, I'll close it. |
Pull Request: Move to Downloadable Plugins
Description
This pull request addresses the following changes:
Changes Made
Benefits
Testing
Additional Notes
Related Issues
Please review and provide feedback on the proposed changes.