Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactors bergamo mapper #28

Merged
merged 2 commits into from
Feb 22, 2024
Merged

feat: refactors bergamo mapper #28

merged 2 commits into from
Feb 22, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #16

  • Updates the interface so that a user defines the job using a pydantic BaseSettings class. The user will need to implement a run_job method
  • Adds an extra unit test module for legacy functions that used to be covered by the old bergamo etl tests
  • In the future, all jobs should be implemented like:
# not necessary to dump to json, but the option makes it easier to run via a rest request
job_settings_json = user_settings.model_dump_json()
etl_job = BergamoEtl(job_settings=job_settings_json)
job_response = etl_job.run_job()

@jtyoung84 jtyoung84 merged commit 9316890 into main Feb 22, 2024
2 checks passed
@jtyoung84 jtyoung84 deleted the feat-16-bergamo-refactor branch February 22, 2024 17:26
@mochic mochic mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor bergamo mapper
3 participants