Create salaries.yml as variables and begin population #3977
Conversation
There was a problem hiding this comment.
Some comments for you @MylesJarvis ! Happy to discuss any as needed
Leading practitioner bit looks fine
The comments are around the structure of the salaries.yml file / naming of the variables - and in a couple of cases, the context of the variables; there are some that are not quite right I think
Also - you have a build error?
Happy for this to go out next week once you've had a chance to look through and make any changes
MylesJarvis
changed the title
We are doing a separate card for changes to the hero section
Implement headteacher salaries (merge into existing Salaries PR)
Co-authored-by: Sarah-DfE <103052329+Sarah-DfE@users.noreply.github.com>
…-summary-salary-implement
…ry-salary-implement Qualified teacher and summary salary implement as variables (Merge into existing Salaries PR)
|
Review app deployed to https://get-into-teaching-app-review-3977.test.teacherservices.cloud |
|
There was a problem hiding this comment.
Hi @gemmadallmandfe, just flagged a few things, mainly for paranoia reasons, but just in case we need to look at them!
app/views/content/landing/how-much-do-teachers-get-paid/_content.html.erb
Show resolved
Hide resolved
Trello card
Context
Changes proposed in this pull request
Current - https://getintoteaching.education.gov.uk/is-teaching-right-for-me/teacher-pay-and-benefits#leading-practitioner-salary
After - https://get-into-teaching-app-review-3977.test.teacherservices.cloud/is-teaching-right-for-me/teacher-pay-and-benefits#leading-practitioner-salary
Guidance to review