Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contentType conversion in TransportFactories classes #92

Merged

Conversation

Kaspiman
Copy link
Contributor

No description provided.

@Kaspiman Kaspiman requested a review from a team as a code owner November 13, 2024 10:17
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (46ba8fb) to head (831502a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #92   +/-   ##
=========================================
  Coverage     88.07%   88.07%           
  Complexity      633      633           
=========================================
  Files           114      114           
  Lines          2599     2599           
=========================================
  Hits           2289     2289           
  Misses          310      310           
Flag Coverage Δ
phpunit 88.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaelreyrol gaelreyrol force-pushed the transport-factory-fix branch from 52d1dcc to 831502a Compare December 22, 2024 11:41
@gaelreyrol
Copy link
Contributor

gaelreyrol commented Dec 22, 2024

Hi @Kaspiman, thanks for your PR, I've permitted myself to edit your changes to add some tests to cover your fixes.
I also removed your TODO, instead I've created an issue to track it.

@gaelreyrol gaelreyrol merged commit 8211d43 into FriendsOfOpenTelemetry:main Dec 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants