Startup steps reduced down to changing one bool value #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
Joshua-Lester3
changed the title
Joshua-Lester3
temporarily deployed
to
BuildAndUploadImage
GitHub Actions
Inactive
This was referenced Oct 15, 2024
BenjaminMichaelis
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit d93cfbe.
BenjaminMichaelis
added a commit
that referenced
this pull request
Oct 23, 2024
This reverts commit d93cfbe.
BenjaminMichaelis
added a commit
that referenced
this pull request
Nov 1, 2024
…restore (#622) ## Description Pull Request #601 implementation fails to restore. I believe I narrowed the problem down to the added `disabledPackageSources` property in nuget.config, though my access to the Nuget feed isn't currently working. This solution takes the disabling effect out of nuget.config and puts it in the Directory.Packages.props. In the .props file it conditionally restores the private Nuget feed based on the single bool prop, `AccessToNugetFeed`, defined in Directory.Build.props. Credit: [GitHub issue 1](NuGet/Home#6045), [GitHub issue 2](NuGet/Home#3972) --------- Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>
Joshua-Lester3
added a commit
to Joshua-Lester3/EssentialCSharp.Web
that referenced
this pull request
Dec 4, 2024
…restore (IntelliTect#622) ## Description Pull Request IntelliTect#601 implementation fails to restore. I believe I narrowed the problem down to the added `disabledPackageSources` property in nuget.config, though my access to the Nuget feed isn't currently working. This solution takes the disabling effect out of nuget.config and puts it in the Directory.Packages.props. In the .props file it conditionally restores the private Nuget feed based on the single bool prop, `AccessToNugetFeed`, defined in Directory.Build.props. Credit: [GitHub issue 1](NuGet/Home#6045), [GitHub issue 2](NuGet/Home#3972) --------- Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Newcomers to this repo are not able to immediately start up the application due to the private nuget feed. My current solution requires newcomers to change two boolean values in configuration files: one in nuget.config to disable the EssentialCSharp package source, and a property in Directory.Build.props to tell lower level config files not to reference ContentFeedNuget, which is inaccessible to those without permissions.