Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AauxiliaryDataHash #4810

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Dec 19, 2024

Description

This is PR adds TxAuxDataHash and deprecates AauxiliaryDataHash in its favor, because it does not follow the naming convention that we use for the rest for the types

Besides that a couple of other cleanup actions:

  • Extract hashTxAuxData into a standalone function, since all current eras have and future eras will have the same imlpementation.
  • Extract indexProxy out of HashAnnotated type class and deprecate it as useless.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/move-crypto-class branch from 9427fcd to 885db90 Compare December 20, 2024 03:27
Base automatically changed from lehins/move-crypto-class to master December 20, 2024 05:39
@lehins lehins force-pushed the lehins/deprecate-auxiliarydatahash branch from 282302b to 9aedc22 Compare December 20, 2024 17:57
@lehins lehins marked this pull request as ready for review December 20, 2024 17:57
@lehins lehins requested a review from a team as a code owner December 20, 2024 17:57
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some trivial remarks.

@lehins lehins force-pushed the lehins/deprecate-auxiliarydatahash branch from f8410db to e8f0bea Compare December 20, 2024 20:52
@lehins lehins enabled auto-merge December 20, 2024 20:52
@lehins lehins merged commit ea1d436 into master Dec 20, 2024
153 of 154 checks passed
@lehins lehins deleted the lehins/deprecate-auxiliarydatahash branch December 20, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants