Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/test-instrumentation: fix shellcheck findings with enableStrictShellChecks enabled #349579

Merged
merged 1 commit into from
Jan 13, 2025
Merged

nixos/test-instrumentation: fix shellcheck findings with enableStrictShellChecks enabled #349579

merged 1 commit into from
Jan 13, 2025
+12 −1

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Oct 18, 2024 •
edited
Loading

Tracking issue #349572

I recommend cherry-picking #349573 (8e6cc2f) to run tests with systemd.enableStrictShellChecks enabled.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 18, 2024
This was referenced Jan 12, 2025
Merged
Open
l0b0
l0b0 approved these changes Jan 12, 2025
View reviewed changes
nixos/modules/testing/test-instrumentation.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 12, 2025
@Scrumplex
nixos/test-instrumentation: fix shellcheck findings with enableStrict…
5c30f8c 
…ShellChecks enabled

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the nixos/test-instrumentation/shellcheck branch from 3702177 to 5c30f8c Compare January 13, 2025 08:05
@Scrumplex Scrumplex merged commit 6d85c05 into NixOS:master Jan 13, 2025
24 of 28 checks passed
@Scrumplex Scrumplex deleted the nixos/test-instrumentation/shellcheck branch January 13, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scrumplex @l0b0 @wegank