Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] contract: Use %m instead of %B to obtain month #1163

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[15.0][IMP] contract: Use %m instead of %B to obtain month #1163

merged 1 commit into from
Dec 20, 2024

Conversation

victoralmau
Copy link
Member

Use %m instead of %B to obtain month

Related to #1153 Fixes #1160

Use the month number to set the text of the month and avoid problems according to the language defined in locale.

Please @pedrobaeza can you review it?

@Tecnativa

@victoralmau
[IMP] contract: Use %m instead of %B to obtain month
f9970f0 
Related to OCA#1153
Fixes OCA#1160

Use the month number to set the text of the month and avoid problems according
to the language defined in locale.
@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 20, 2024
pedrobaeza
pedrobaeza approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this approach is more resilient and doesn't have any side effect. As it doesn't mean any change at user level, let's fast-track:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1163-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at de37f24. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit df86262 into OCA:15.0 Dec 20, 2024
5 checks passed
@pedrobaeza pedrobaeza deleted the 15.0-imp-contract-issue1160 branch December 20, 2024 16:34
@Bilbonet
Copy link

Really cool 🫶
Thanks @victoralmau

This was referenced Jan 7, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @OCA-git-bot @Bilbonet @pedrobaeza