Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_dm,rtl] Fix acknowledgment of reset in dmstatus.allhavereset/dmstatus.anyhavereset #15123

Closed
andreaskurth opened this issue Sep 26, 2022 · 2 comments
Assignees
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_dm Priority:P1 Priority: high Type:Bug Bugs

Comments

@andreaskurth
Copy link
Contributor

andreaskurth commented Sep 26, 2022

pulp-platform/riscv-dbg#118:

Currently the debug module seems to assume any assertion of ndmreset_o will instantly cause a reset. The dmstatus.allhavereset/dmstatus.anyhavereset bits are set purely on ndmreset_o being asserted rather than any acknowledgement a reset has occurred.

This is incorrect behavior and should be fixed, but it is currently not urgent for us, because the rstmgr resets the system reset domain unconditionally whenever ndmreset_req is asserted (a few cycles after asserting this signal).

estimate 12

@andreaskurth
Copy link
Contributor Author

Triaged for rv_dm. Assigning to M2.5 with Priority:P3 Priority: low because there are only a few clock cycles (between the assertion of ndmreset_o and the instant rstmgr resets the system) during which those bits are not correct -- so I think this can be easily worked around in software without noticeable impact, whereas the RTL changes involved in proper reset acknowledgment are out of scope for this release IMHO.

@msfschaffner
Copy link
Contributor

Depending on how we intend to implement the delayed debug unlock feature, this may be something that we have to fix as well.

CC @rswarbrick

@msfschaffner msfschaffner added Priority:P1 Priority: high and removed Priority:P3 Priority: low labels Mar 12, 2024
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 14, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 14, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 14, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 14, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 15, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 15, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 15, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
a-will pushed a commit to msfschaffner/opentitan that referenced this issue Mar 15, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
a-will pushed a commit to msfschaffner/opentitan that referenced this issue Mar 15, 2024
This adds tracking logic for NDM reset requests and issues an
acknowledgement to the DM_CSRs so that dmstatus.allhavereset /
dmstatus.anyhavereset can be asserted at the correct time.

Fixes lowRISC#15123

Signed-off-by: Michael Schaffner <msf@opentitan.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:rv_dm Priority:P1 Priority: high Type:Bug Bugs
Projects
None yet
Development

No branches or pull requests

3 participants