Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

feat(gen) add grunt-ngdoc #551

Closed
wants to merge 1 commit into from

Conversation

marcin-wosinek
Copy link
Contributor

Add jsdoc to generated text and add grunt-ngdocs generated documentation
to /docs.

Add grunt-ngdocs to package.json & Gruntfile.js. Basic support in js templates.
Watch for changes in js files & autoreload docs after regeneration.

Init work at #550

Example:
documentation

@eddiemonge
Copy link
Member

How does this play with the CoffeeScript versions of the files? What about when/if TypeScript is added?

@marcin-wosinek
Copy link
Contributor Author

Definitely should be supported as well. If there is a way to write comments in coffee/typeScript and have them preserved after compilation this should be easy to accomplished on generator part.

@marcin-wosinek
Copy link
Contributor Author

Example documentation is served on the github page. Suggestions to wording are welcome.

@marcin-wosinek
Copy link
Contributor Author

For jsdoc in coffee I try something like here. For typescript there is less resources, but comments syntax seems to be quite similar to js.

@eggers
Copy link
Contributor

eggers commented Jan 21, 2014

I was able to get this working with typescript with a couple changes. I just copied the docs from the js templates to the ts templates. I also had to modify the ngdoc task to include the path of the generated js files (this would also need to be done for coffeescript)

see: https://github.com/eggers/generator-angular/tree/ngdocs

@eggers
Copy link
Contributor

eggers commented Jan 22, 2014

Thanks, @marcin-wosinek I just made the one change I proposed.

'partials/{,*/}*.html',
'css/*.css',
'js/*.js',
'js/*.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why double js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad.

@NewMediaRoc
Copy link

+1 please do merge!

@eddiemonge
Copy link
Member

Haven't forget about this but need to do some more testing and other things first

@eddiemonge
Copy link
Member

Can you split this into two PRs? One that has all the comments/docs and the other for the Gruntfile? For the comments, can you also add the same things to the CS fileS?

@sindresorhus
Copy link
Member

ping @marcin-wosinek

Add jsdoc to generated text and add grunt-ngdocs generated documentation
to /docs.

Add grunt-ngdocs to package.json & Gruntfile.js. Basic support in js & coffee
templates. Watch for changes in files & autoreload docs after regeneration.

Init work at yeoman#550
@marcin-wosinek
Copy link
Contributor Author

Ok rebased & splited.

@marcin-wosinek marcin-wosinek deleted the ngdocs branch May 13, 2014 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants